🐛 Fix e2e tests for branch protection #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
azeemshaikh38,
justaugustus and
naveensrinivasan
as code owners
laurentsimon
force-pushed
the
bug/e2ebranch
branch
from
b17e16c to
269f922
Compare
Codecov Report
@@ Coverage Diff @@
## main #1837 +/- ##
=======================================
Coverage 53.51% 53.51%
=======================================
Files 73 73
Lines 6692 6692
=======================================
Hits 3581 3581
Misses 2865 2865
Partials 246 246 |
|
@naveensrinivasan I think this one may fix it. I tested locally and it worked. Fingers crossed. |
|
tentatively merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the unit tests, see #1834
It turns out that the ginkgo's
Skip()function only works in theIt()function.Fix e2e tests for branch protection
no breaking changes